Fix deallocate issue of parameter_files (#279)

Correct pointer arithmetic on parameter_files to avoid deallocate memory out-of-bounds Signed-off-by: Chris Ye <chris.ye@intel.com>
ros2 · Aug 16, 2018 · adc0190 · adc0190
1 parent 696f62c
commit adc0190
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/rcl/src/rcl/arguments.c b/rcl/src/rcl/arguments.c
@@ -91,10 +91,13 @@ rcl_arguments_get_param_files(
   }
   for (int i = 0; i < arguments->impl->num_param_files_args; ++i) {
     (*parameter_files)[i] = rcutils_strdup(arguments->impl->parameter_files[i], allocator);
-    if (NULL == *parameter_files) {
+    if (NULL == (*parameter_files)[i]) {
       // deallocate allocated memory
       for (int r = i; r >= 0; --r) {
-        allocator.deallocate((*parameter_files[i]), allocator.state);
+        if (NULL == (*parameter_files[r])) {
+          break;
+        }
+        allocator.deallocate((*parameter_files[r]), allocator.state);
       }
       allocator.deallocate((*parameter_files), allocator.state);
       (*parameter_files) = NULL;