Foxy backport: Fix target_link_directories/link_directories in cmake (#29)

[clalancette]

Signed-off-by: ahcorde ahcorde@gmail.com

Otherwise, Foxy fails to build on Ubuntu 18.04.

[ahcorde]

Do you mind to sign the commit ?

[clalancette]

Do you mind to sign the commit ?

Oops, yeah, good point. Will do.

[clalancette]

There we go, DCO bot is happier now.

[clalancette]

CI:

• Linux
• Linux-aarch64
• macOS
• Windows

[clalancette]

@jacobperron Both Linux CIs have failing tests in sros2, macOS has a small set of failures, and Windows has an even larger set of failures. It seems pretty unlikely to me that any of these test failures were caused by this PR, but could you take a quick look? Thanks.

[jacobperron]

The last time I recall running a full CI for Foxy was in December: ros2/ros2#1070
I've seen the sros2 and laser_geometry test failures before, but the ros2doctor failure on macOS and the others on Windows look new to me. I agree that it seems unlikely that this PR would cause those to start failing. It's possible something else changed that is causing those to fail. Maybe it's a good time to trigger a full Foxy build to see where our baseline is now.

[jacobperron]

Maybe it's a good time to trigger a full Foxy build to see where our baseline is now.

Here we go: ros2/ros2#1090

[clalancette]

Here we go: ros2/ros2#1090

Thanks, appreciated. I'll make a decision on whether to merge this PR once those results come back.

[clalancette]

Hm. Well, while there is a bunch of overlap between the CI job here and the one that Jacob pointed to, it's not 100%. There are some failures here that are not in the unmodified job. I still think it is unlikely that this change is the cause of those failures, but I'll hold off on merging this for now.

[clalancette]

I'm going to go ahead and merge this regardless of the warnings. I highly doubt it is because of this PR.