Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Examples for launching composable nodes #168

Closed
wants to merge 2 commits into from
Closed

Examples for launching composable nodes #168

wants to merge 2 commits into from

Conversation

sloretz
Copy link
Contributor

@sloretz sloretz commented Jan 29, 2019

Part of #160, opening for discussion

This adds examples for launching composable nodes. One is the same as slide 8 of https://roscon.ros.org/2018/presentations/ROSCon2018_launch.pdf with ExecuteComposableNodeProcess renamed to ComposableNodeContainer and ComposableNodeDescription renamed to ComposableNode. The other example assumes an OnProcessStart event handler is created.

@sloretz sloretz added the in review Waiting for review (Kanban column) label Jan 29, 2019
@sloretz sloretz self-assigned this Jan 29, 2019
wjwwood
wjwwood reviewed Jan 29, 2019
View reviewed changes
Copy link
Member

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than my suggested alternative, I think this looks good.

launch_ros/composition_by_event_launch.py Show resolved Hide resolved
hidmic
hidmic reviewed Jan 30, 2019
View reviewed changes
Copy link
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I agree w/ William

mjcarroll
mjcarroll approved these changes Jan 31, 2019
View reviewed changes
Copy link
Member

@mjcarroll mjcarroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sloretz sloretz mentioned this pull request Feb 1, 2019
Merged
@sloretz
Copy link
Contributor Author

sloretz commented Feb 1, 2019

I'll close this PR for now and reopen when an implementation is ready

@sloretz sloretz closed this Feb 1, 2019
This was referenced Mar 22, 2019
Closed
Closed
@wjwwood wjwwood deleted the launch_ros_composition branch April 22, 2021 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hidmic hidmic hidmic left review comments

@mjcarroll mjcarroll mjcarroll approved these changes

@wjwwood wjwwood wjwwood approved these changes

Assignees

@sloretz sloretz

Labels
in review Waiting for review (Kanban column)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sloretz @wjwwood @mjcarroll @hidmic