Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the shutdown handling in all of the Python examples. #379

Merged

Commits on May 3, 2024

  1. Update the shutdown handling in all of the Python examples.

    In particular, we should deal with KeyboardInterrupt (by
    just doing 'pass'), as well as ExternalShutdownException
    (which can come from the executor).  In all cases, we should
    call 'rclpy.try_shutdown()' to cleanup at the end.
    
    Note well that I removed some of the *destroy() calls in
    the cleanup.  That's because they weren't correct in all cases,
    and to fix them up properly would really require us to have
    a nested set of try..except statements.  Given that these are
    examples, having that complex set of exception handling didn't
    seem like the correct way to go here.
    
    Signed-off-by: Chris Lalancette <clalancette@gmail.com>
    clalancette committed May 3, 2024
    Configuration menu
    Copy the full SHA
    70d4703 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. Fixes from review.

    Signed-off-by: Chris Lalancette <clalancette@gmail.com>
    clalancette committed May 7, 2024
    Configuration menu
    Copy the full SHA
    36239ad View commit details
    Browse the repository at this point in the history