Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Actions proposal #193

Merged
merged 76 commits into from
Mar 14, 2019
Merged

Actions proposal #193

Show file tree
Hide file tree
Changes from 70 commits
Commits
Show all changes
76 commits
Select commit Hold shift + click to select a range
104df38
Add original proposal
gbiggs Aug 1, 2018
cc48341
Reformat and revise some of the information
gbiggs Aug 1, 2018
b3edf0a
Fix missing close preformat
gbiggs Aug 1, 2018
ded103a
Merge branch 'gh-pages' of https://github.com/gbiggs/design into acti…
sloretz Oct 10, 2018
29e0280
ROS 2 action server always generates goal id
sloretz Oct 10, 2018
cfe4e66
Rough description of services and topics
sloretz Oct 10, 2018
c00f875
ROS 1 cancels goals with stamps less than or equal to given time
sloretz Oct 10, 2018
68320a4
Add API section for action server
jacobperron Oct 10, 2018
85dba7d
Actions implemented in rcl
sloretz Oct 10, 2018
d3dc0be
Merge branch 'actions_proposal' of github.com:ros2/design into action…
sloretz Oct 10, 2018
da638a9
More italics
sloretz Oct 10, 2018
45a7d0b
QoS warning for goal submission service
sloretz Oct 10, 2018
b263fd3
Add API section for action client
jacobperron Oct 10, 2018
508247f
call -> calls
sloretz Oct 10, 2018
98d2ba5
Server discards result after giving it to the client
sloretz Oct 10, 2018
7782276
Actions namespaced separately from msg and srv definitions
sloretz Oct 10, 2018
23e942b
Shrink possible statuses
sloretz Oct 10, 2018
4efd85e
Replace high-level API section with details about goal states
jacobperron Oct 10, 2018
0d83eb8
Begin section about bridging ROS 1 and ROS 2
sloretz Oct 10, 2018
8b97ce8
Add Action Server C++ examples
jacobperron Oct 11, 2018
2c7e9e3
Move SimpleActionServer example to separate section
jacobperron Oct 11, 2018
2fb606c
Add include and type alias to action server example
jacobperron Oct 11, 2018
95f6ad3
Add Action Client C++ examples
jacobperron Oct 11, 2018
8d9ccbf
Bridge R1 client and R2 server expanded
sloretz Oct 11, 2018
d70f38f
Merge branch 'actions_proposal' of github.com:ros2/design into action…
sloretz Oct 11, 2018
1a5d958
Move API examples to examples repo
jacobperron Oct 11, 2018
bde9d09
Rough start to bridging ROS 1 server and ROS 2 client
sloretz Oct 11, 2018
224f081
Merge branch 'actions_proposal' of github.com:ros2/design into action…
sloretz Oct 11, 2018
d634a61
Update goal state machine
jacobperron Oct 11, 2018
4c856b2
Move bridge to bottom
sloretz Oct 11, 2018
244c3f4
Link to python actions api
sloretz Oct 11, 2018
63530b5
minor grammar
jacobperron Oct 11, 2018
08c106b
Update background
jacobperron Oct 11, 2018
d92fcce
Move Goal identifier section and add more rationale
sloretz Oct 11, 2018
8076d96
Minor wording in goal subscription service section
sloretz Oct 11, 2018
5a9ccd0
Simplify explanation of why actions aren't in rmw
sloretz Oct 11, 2018
9ed5359
Reword goalid sentences
sloretz Oct 11, 2018
0172831
Stub alternatives section
sloretz Oct 12, 2018
ad1dd1f
Start section of ROS 1 vs ROS 2 and move stuff to it
sloretz Oct 12, 2018
70b5f8e
Delete content in bridge section
sloretz Oct 12, 2018
8abbb23
Remove realtime section stub
sloretz Oct 12, 2018
69e36b7
Services promoted to 1 section type higher
sloretz Oct 12, 2018
1cce6b6
Move rmw note to alternatives section
sloretz Oct 12, 2018
2c104af
More content in differences section
sloretz Oct 12, 2018
d71f0d1
move differences higher up
sloretz Oct 12, 2018
53c0e3c
specification -> Interface Definition
sloretz Oct 12, 2018
0f587c0
Add goal lifecycle examples
jacobperron Oct 12, 2018
e12ab46
Note about visibility of topics and services
sloretz Oct 12, 2018
72894ea
Shorten abstract
sloretz Oct 12, 2018
5e6af9c
Rename 'goal lifecycle' examples to 'interaction' examples
jacobperron Oct 12, 2018
3404684
Shorten introduction section
sloretz Oct 12, 2018
9ecd148
Merge branch 'actions_proposal' of github.com:ros2/design into action…
sloretz Oct 12, 2018
d6f7333
Shorten sentence
sloretz Oct 12, 2018
e24800a
Minor rewording at start
sloretz Oct 12, 2018
d7323ec
Reword/reformat section about entities involved in an action
sloretz Oct 12, 2018
206f6be
Make fragments in Action Inteface Definition complete sentences
sloretz Oct 12, 2018
86b2e30
Introdice state machine before diagram
sloretz Oct 12, 2018
94b9306
move introspection tools section higher
sloretz Oct 12, 2018
9706472
Slight formating chnages to introspection tools section
sloretz Oct 12, 2018
8187434
Status topic is a list
sloretz Oct 12, 2018
1e7e6bb
grammar requires ;
sloretz Oct 12, 2018
daa529e
1 sentece becomes 2
sloretz Oct 12, 2018
5de40c7
Add actions interaction overview diagram
jacobperron Oct 12, 2018
887ad87
Update goal state machine
jacobperron Oct 16, 2018
afaf5f3
Fix typos and grammer, consistency in lingo, and let action clients g…
jacobperron Oct 16, 2018
7b5144e
Add a couple sentences regarding QoS for action feedback and status t…
jacobperron Oct 16, 2018
77216b1
Add section about using multiple topics for feedback/status in 'Alter…
jacobperron Oct 16, 2018
a6144c7
Fix logic in cancel policy
jacobperron Oct 18, 2018
ad1b326
Minor clarifications
jacobperron Oct 31, 2018
a439740
Add topic and service name generation
sloretz Nov 1, 2018
1ff406d
Address feedback from review
jacobperron Feb 13, 2019
b7ac32a
Add sub-section to alternavtives on action server goal ID generation
jacobperron Feb 14, 2019
0baa626
Update interaction example diagram
jacobperron Feb 14, 2019
d72d100
Fix author line
jacobperron Feb 14, 2019
1c98b9b
Add third action interfaction example
jacobperron Feb 14, 2019
f4b59fa
Fix typos, broken link, and rename goal events
jacobperron Mar 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading