Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use nightly for style check #396

Merged
merged 5 commits into from
May 13, 2024
Merged

Use nightly for style check #396

merged 5 commits into from
May 13, 2024
+28 −22

Conversation

mxgrey
Copy link
Collaborator

@mxgrey mxgrey commented Apr 30, 2024 •
edited
Loading

Related to #395

mxgrey added 4 commits April 30, 2024 09:14
@mxgrey
Use nightly for style check
3992efe 
Signed-off-by: Michael X. Grey <mxgrey@intrinsic.ai>
@mxgrey
Install nightly for cargo +nightly fmt
6974c3a 
Signed-off-by: Michael X. Grey <mxgrey@intrinsic.ai>
@mxgrey
Fix style in examples
5357002 
Signed-off-by: Michael X. Grey <mxgrey@intrinsic.ai>
@mxgrey
Update style for rosidl_runtime_rs
35e8bb3 
Signed-off-by: Michael X. Grey <mxgrey@intrinsic.ai>
@mxgrey mxgrey mentioned this pull request Apr 30, 2024
Closed
maspe36
maspe36 previously approved these changes Apr 30, 2024
View reviewed changes
Copy link
Collaborator

@maspe36 maspe36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment in the rustfmt file mentioning that it requires nightly?

Or perhaps we should have a tracking issue like this?

esteve
esteve previously approved these changes May 2, 2024
View reviewed changes
Copy link
Collaborator

@esteve esteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mxgrey thanks! I agree with @maspe36 , a comment about style checking requiring nightly would be nice

@mxgrey
Add a comment indicating that nightly release is needed for formatting
0aaf01d 
Signed-off-by: Michael X. Grey <mxgrey@intrinsic.ai>
@mxgrey mxgrey dismissed stale reviews from esteve and maspe36 via 0aaf01d May 2, 2024 09:16
esteve
esteve approved these changes May 2, 2024
View reviewed changes
Copy link
Collaborator

@esteve esteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mxgrey LGTM, thanks!

@mxgrey
Copy link
Collaborator Author

mxgrey commented May 2, 2024

Comment added in 0aaf01d

I think opening an issue is fine, but realistically I'm not expecting this situation to change in the foreseeable future. It seems that a surprising number of rustfmt settings have been stuck on nightly for many years.

@maspe36 maspe36 merged commit 2e746d6 into ros2-rust:main May 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maspe36 maspe36 maspe36 approved these changes

@esteve esteve esteve approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mxgrey @esteve @maspe36