Fixes multiple runtime issues #126
Conversation
Fix rosidl deprecation warning
…ndle. got a nullrefexception
|
@timonmentink Thanks for the contributions 👍 Currently somewhat busy, but hope to get to review this soon. |
|
Seems like pre Humble uses python_executable. Created a list that contains all the newer distro`s for easy checks. Builds now working on own branch :) |
There was a problem hiding this comment.
Finally had time to look at this.
Did try to build this on my machine, but both foxy and humble did not build, see comment below.
Have some other small changes and questions as well.
Thanks for your contribution, seems like you have got ros2_dotnet to work on windows again :)
rosidl_generator_dotnet/cmake/rosidl_generator_dotnet_generate_interfaces.cmake
Outdated
Show resolved
Hide resolved
rosidl_generator_dotnet/cmake/rosidl_generator_dotnet_generate_interfaces.cmake
Outdated
Show resolved
Hide resolved
rosidl_generator_dotnet/cmake/rosidl_generator_dotnet_generate_interfaces.cmake
Outdated
Show resolved
Hide resolved
|
After a long time, i hopefully fixed the issues :) |
I have been busy as well for some time. Became a father some weeks ago, so my spare time for contributing here was blocked by preparing things at home ;)
Seems like you are the first one to get this working with humble on windows (who published this online). Could you comment on this issue about it? Are there still some workarounds needed or missing documentation to get it working on windows? If it should work out of the box from your perspective I would close that issue. |
Fixed multiple issues in this PR.
I have ros2-dotnet now building & working examples under Windows 10 + Humble & Ubuntu 22.04 + Humble.
There where some typo`s, missing functions in _native.dll and old dll loading functions.