Upstream compatibility #1119
Closed
Upstream compatibility #1119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compatibility for ros/genpy#79.
Due to scheduling / resource contention, `sleep`s and `wait_until`s may be delayed. The `SteadyTimerHelper` test class was not robust to these delays, which was likely the cause of a failing test (`multipleSteadyTimeCallbacks` in `timer_callbacks.cpp`:220).
kmactavish
force-pushed
the
upstream-compatibility
branch
5 times, most recently
from
f5f54d7 to
6cc95f9
Compare
kmactavish
force-pushed
the
upstream-compatibility
branch
4 times, most recently
from
a1527f3 to
04c43ed
Compare
kmactavish
force-pushed
the
upstream-compatibility
branch
from
04c43ed to
03b16eb
Compare
dirk-thomas
reviewed
Aug 9, 2017
| } | ||
| ROS_FATAL_STREAM("Done testing the message"); |
There was a problem hiding this comment.
I think the problem you are trying to identify here has been addressed by #1127.
|
@ros-pull-request-builder retest this please |
|
Thank you for the patch. It was very helpful in addressing the test failures.
|
|
@dirk-thomas Awesome, I couldn't track that one down. Thanks. |
I just ran the test executable in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a number of upstream changes that broke tests. This PR aims to get lunar-devel passing tests again so PRs aren't failing.
sleeps andwait_untils may be delayed. TheSteadyTimerHelpertest class was not robust to these delays, which was likely the cause of a failing test in Avoids buffer overflow in xmlrpcpp if fd > 1024 #1113 (multipleSteadyTimeCallbacks in timer_callbacks.cpp:220), and forcing retests when Add SteadyTimer #1014 was being considered.