Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for uncrustify 0.72 #11

Merged
merged 1 commit into from
Dec 17, 2021
Merged

Fixes for uncrustify 0.72 #11

merged 1 commit into from
Dec 17, 2021

Conversation

clalancette
Copy link
Contributor

Signed-off-by: Chris Lalancette clalancette@openrobotics.org

Links to ament/uncrustify_vendor#27 ; see that PR for more information and CI.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
@clalancette clalancette marked this pull request as ready for review December 17, 2021 15:25
@clalancette clalancette requested a review from a team as a code owner December 17, 2021 15:25
@clalancette clalancette requested review from gbiggs and christophebedard and removed request for a team December 17, 2021 15:25
@clalancette
Copy link
Contributor Author

@MichaelOrlov @emersonknapp @gbiggs @christophebedard This PR has to go in concurrently with all of the PRs listed in ament/uncrustify_vendor#27 (if we merge it before or after, we are going to break CI). As it stands, I don't have write access to this repository, so I can't actually do the merge here. A couple of solutions come to mind:

  1. Someone can give me (temporary) write access so I can do this merge
  2. Someone can be ready to do the merge when I go ahead and merge the uncrustify_vendor PR and all of the siblings.

Either works for me, we just need to coordinate. Thoughts?

Copy link
Member

@christophebedard christophebedard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Local CI fails because it's not using ament/uncrustify_vendor#27, so it's alright.

@christophebedard
Copy link
Member

Either works for me, we just need to coordinate. Thoughts?

I can merge it whenever you're ready.

@clalancette
Copy link
Contributor Author

I can merge it whenever you're ready.

All right, sounds good. I'll start merging the rest of the PRs soon here, and ping back once the rest of them are in.

@clalancette
Copy link
Contributor Author

@christophebedard OK, all of the rest of the PRs have been merged. This one is ready to merge when you are ready.

@christophebedard christophebedard merged commit 579878c into ros-tooling:main Dec 17, 2021
@clalancette
Copy link
Contributor Author

Thank you so much!

@clalancette
Copy link
Contributor Author

@christophebedard If you get a chance, a new release of keyboard_handler into Rolling would be appreciated. Until that gets done, all of the Rpr jobs to this repository are going to fail.

@christophebedard
Copy link
Member

@clalancette I could tag a new release, but I don't have access to the release repo (https://github.com/ros2-gbp/keyboard_handler-release). @emersonknapp could probably do it at some point.

@emersonknapp
Copy link
Contributor

Thanks for taking care of all this while I was on vacation - I'll cut a new release today.

@emersonknapp
Copy link
Contributor

ros/rosdistro#31533

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants