-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for uncrustify 0.72 #11
Fixes for uncrustify 0.72 #11
Conversation
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
@MichaelOrlov @emersonknapp @gbiggs @christophebedard This PR has to go in concurrently with all of the PRs listed in ament/uncrustify_vendor#27 (if we merge it before or after, we are going to break CI). As it stands, I don't have write access to this repository, so I can't actually do the merge here. A couple of solutions come to mind:
Either works for me, we just need to coordinate. Thoughts? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Local CI fails because it's not using ament/uncrustify_vendor#27, so it's alright.
I can merge it whenever you're ready. |
All right, sounds good. I'll start merging the rest of the PRs soon here, and ping back once the rest of them are in. |
@christophebedard OK, all of the rest of the PRs have been merged. This one is ready to merge when you are ready. |
Thank you so much! |
@christophebedard If you get a chance, a new release of |
@clalancette I could tag a new release, but I don't have access to the release repo (https://github.com/ros2-gbp/keyboard_handler-release). @emersonknapp could probably do it at some point. |
Thanks for taking care of all this while I was on vacation - I'll cut a new release today. |
Signed-off-by: Chris Lalancette clalancette@openrobotics.org
Links to ament/uncrustify_vendor#27 ; see that PR for more information and CI.