Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix final confusion between format and encoding. #275

Open
wants to merge 1 commit into
base: melodic
Choose a base branch
from

Conversation

talregev
Copy link
Contributor

Fix final confusion between format and encoding.
Format is file format like jpg, bmp and more,
encoding is color encoding like bgr8, rgb8 and more.

@talregev
Copy link
Contributor Author

I think the build fail not because of my changes. Is minor changes.
I compile the code on my computer with ros melodic and it compile and run fine.

Format is file format like jpg, bmp and more,
encoding is color encoding like bgr8, rgb8 and more.
@talregev
Copy link
Contributor Author

Not sure why my pr is fail. Can you check?
I just rename variables names.

@talregev talregev mentioned this pull request Jun 22, 2019
@ijnek ijnek self-assigned this Sep 7, 2022
@ijnek
Copy link
Member

ijnek commented Sep 12, 2022

@ros-pull-request-builder retest this please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants