new: LaserScan to PointCloud node + nodelet #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR is failing due to roslint check in existing files, #29 should address this issue |
|
Retrigger ci |
paulbovbel
reviewed
May 1, 2019
| { | ||
| sensor_msgs::PointCloud2Ptr scan_cloud; | ||
| scan_cloud.reset(new sensor_msgs::PointCloud2); | ||
| projector_.projectLaser(*scan_msg, *scan_cloud); |
There was a problem hiding this comment.
there's a more accurate way to transform a laserscan into a pointcloud, that takes into account the movement of the laser. it's probably not typically useful here if the target frame is moving (i.e. on a robot)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should address
#27