Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of boost from polygon_filter #209

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

traversaro
Copy link
Contributor

The PR #161 removed all uses of boost from the library, however #189 re-introduced the use of boost in polygon_filter, but without reintroducing the required CMake code and package.xml metadata.

This PR removes the use of boost from polygon_filter, like #161 did for the rest of the library.

@jonbinney
Copy link
Contributor

Something happening in the rolling tests with the renamed tf2 headers - i'll take a closer look this week.

@jonbinney
Copy link
Contributor

CI is failing on rolling because laser_geometry switched to use the newly provided hpp header for buffer_core from tf2, but the docker container used by CI has an old version of tf2 from before that hpp file was added. Since the failure is not due to this PR (and the main ros2 branch will fail CI in the same way right now) I'm OK merging this.

Copy link
Contributor

@jonbinney jonbinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonbinney jonbinney merged commit bbc883d into ros-perception:ros2 Jan 17, 2025
3 of 4 checks passed
@traversaro
Copy link
Contributor Author

CI is failing on rolling because laser_geometry switched to use the newly provided hpp header for buffer_core from tf2, but the docker container used by CI has an old version of tf2 from before that hpp file was added. Since the failure is not due to this PR (and the main ros2 branch will fail CI in the same way right now) I'm OK merging this.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants