Skip to content

Use MOTOR_LEFT/RIGHT instead of hardcoding #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 4, 2021
Merged

Use MOTOR_LEFT/RIGHT instead of hardcoding #42

merged 1 commit into from
Nov 4, 2021

Conversation

joeuser846
Copy link
Contributor

Allows motor (port) defines to work as intended

fjp
fjp approved these changes Nov 4, 2021
View reviewed changes
Copy link
Member

@fjp fjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for getting rid of those magic numbers :-)

@fjp fjp merged commit 327f395 into ros-mobile-robots:noetic-devel Nov 4, 2021
@joeuser846 joeuser846 deleted the motor-defines branch November 4, 2021 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjp fjp fjp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joeuser846 @fjp