Add OS_RASPBIAN #244
Merged
Add OS_RASPBIAN #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should set up an alias in rosdep as soon as possible so that when we're ready to switch raspbian to detecting separately from Debian, we don't break rosdep.
tfoote
approved these changes
Feb 24, 2022
There was a problem hiding this comment.
This looks good. The risk of compatibility is if the user updates rospkg detection but doesn't update rosdep to do the aliasing. To that end a conflict with rosdep less than aliasing does guarantee accuracy, it doesn't get every case, but will get the majority and hopefully people running from pip are generally updating everything or pinning everything.
nuclearsandwich
approved these changes
Feb 24, 2022
This was referenced May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should set up an alias in rosdep as soon as possible so that when we're ready to switch raspbian to detecting separately from Debian, we don't break rosdep.
The steps to getting where we want to be:
OS_RASPBIANavailable and releaserospkgrosdepto aliasOS_RASPBIANtoOS_DEBIANand releaserosdeprosdepis widely availablerospkgto detect Raspbian asOS_RASPBIANWe may want to make
rospkgconflict withrosdepversions which don't have theOS_RASPBIANalias. We don't have the ability to do that in pip, but we could at least do it in the debs and RPM packages. It might save someone a headache at some point.