Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable lunr.js stemming. #196

Merged
merged 1 commit into from
Jan 4, 2020
Merged

Disable lunr.js stemming. #196

merged 1 commit into from
Jan 4, 2020

Conversation

hidmic
Copy link

@hidmic hidmic commented Nov 29, 2019

Closes #178. This pull request is actually a workaround, not a solution. Checking lunr.js issues upstream like olivernn/lunr.js#413 and olivernn/lunr.js#328 I've came to the conclusion that we won't get autocomplete like behavior from lunr.js. So, for the time being, I'll just disable stemming. This way, python_cmake_mod or cmake_module won't find python_cmake_module but python_cmake_mod* or *_cmake_module will, consistently.

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Copy link
Member

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well that's not what I'd have expected from that "feature"

@tfoote tfoote merged commit 38c8835 into ros2 Jan 4, 2020
@tfoote tfoote deleted the hidmic/disable-stemming branch January 4, 2020 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confusingly incomplete search results
2 participants