Add MoveIt Servo Tutorial #688
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
tahsinkose
force-pushed
the
tahsin/add-moveit-servo-tutorial
branch
from
e365194
to
d0913a8
Compare
|
@RobertWilbrandt @fmauch could you please have a look at this PR? |
AndyZe
reviewed
Nov 2, 2024
ur5_moveit_tutorials/CMakeLists.txt
Outdated
Comment on lines
6
to
9
| catkin_package( | ||
| ) | ||
| include_directories( | ||
| ) |
There was a problem hiding this comment.
Suggested change
| catkin_package( | |
| ) | |
| include_directories( | |
| ) | |
| catkin_package() |
| <!-- Load and start the controllers listed in the 'controllers' arg. --> | ||
| <node name="ros_control_controller_spawner" pkg="controller_manager" type="spawner" | ||
| args="$(arg controllers)" output="screen" respawn="false" /> | ||
| <group unless="$(eval arg('controllers') == '')"> |
There was a problem hiding this comment.
I don't think there's any reason for group if there's just one node in the group? Suggest reverting.
There was a problem hiding this comment.
I should actually have used if clause instead of this 😄
…on to work together.
…ntroller based MoveIt servo.
tahsinkose
force-pushed
the
tahsin/add-moveit-servo-tutorial
branch
from
d0913a8
to
1e65d66
Compare
|
@AndyZe addressed your review, PTAL 🙏🏼
I can migrate them to ROS 2 when I finally switch to ROS 2 🙈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two usage examples of MoveIt Servo with UR5 robot in the new
ur5_moveit_tutorialspackage