feature/InstallSpaceUpdate #61
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
de-vri-es
previously approved these changes
Oct 26, 2019
|
Thanks for the PR @colin-lewis-ut, and sorry for the slow response! Would you mind making your branch up-to-date with the base branch? |
colin-lewis-19
force-pushed
the
feature
branch
from
e8d359b to
839031a
Compare
|
This should be up to date with master now |
simonschmeisser
approved these changes
Dec 17, 2019
|
@jontje this looks good and should be merged :) |
|
I have forgotten to let you know that PR #69, which was created after my last comment, will turn this library into a plain cmake package. That PR includes an adoption of the correct install space fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
minor fix to install space