Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create CONTRIBUTING.md #16

Closed
wants to merge 1 commit into from
Closed

Conversation

tfoote
Copy link

@tfoote tfoote commented Jul 12, 2018

@jontje
Copy link
Contributor

jontje commented Aug 7, 2018

Sorry for the slow response, I recently got back from vacation and I had a pile of stuff to go through.

I assume this is something commonly added to ROS-Industrial repos, is that correct?

@gavanderhoorn
Copy link
Member

See my comment in ros-industrial/abb_libegm#13 (comment).

@gavanderhoorn
Copy link
Member

gavanderhoorn commented Jun 13, 2019

@jontje: could you take a look at the file contributed here whether it would be OK for inclusion in this repository?

If not, we should close this PR. I'm tracking the need to create guidelines for this repository in #52.

@jontje
Copy link
Contributor

jontje commented Jun 14, 2019

Yes, this is long overdue, I will look at it today.

Copy link
Contributor

@jontje jontje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the first section there is a reference to a figure, and later in the document there are several items mentioned that I assume are part of it. @tfoote or @gavanderhoorn, is this figure available somewhere?

Also, numbers 7. - 9. are not currently applicaple to this repository. Maybe remove them for now? And add a note like "Note: Items 7 to 9, in the figure, are currently not applicaple to this repository." just before the last line?

@@ -0,0 +1,21 @@
ROS-Industrial is a community project. We welcome contributions from any source, from those who are extremely active to casual users. The following sections outline the steps on how to contribute to ROS-Industrial. It assumes there is an existing repository to which one would like to contribute (item 1 in the figure above) and one is familiar with the Git "Fork and Branch" workflow, detailed [here](http://blog.scottlowe.org/2015/01/27/using-fork-branch-git-workflow/).

1. Before any development is undertaken, a contributor would communicate a need and/or issue to the ROS-Industrial community. This can be done by submitting an issue on the appropriate GitHub repo, the [issues repo](https://github.com/ros-industrial/ros_industrial_issues), or by posting a message in the [ROS-Industrial category on ROS Discourse](//swri-ros-pkg-dev@googlegroups.com). . Doing so may save you time if similar development is underway and ensure that whatever approach you take is acceptable to the community of reviewers once it is submitted.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. Before any development is undertaken, a contributor would communicate a need and/or issue to the ROS-Industrial community. This can be done by submitting an issue on the appropriate GitHub repo, the [issues repo](https://github.com/ros-industrial/ros_industrial_issues), or by posting a message in the [ROS-Industrial category on ROS Discourse](//swri-ros-pkg-dev@googlegroups.com). . Doing so may save you time if similar development is underway and ensure that whatever approach you take is acceptable to the community of reviewers once it is submitted.
1. Before any development is undertaken, a contributor would communicate a need and/or issue to the ROS-Industrial community. This can be done by submitting an issue on the appropriate GitHub repo, the [issues repo](https://github.com/ros-industrial/ros_industrial_issues), or by posting a message in the [ROS-Industrial category on ROS Discourse](https://discourse.ros.org/c/ros-industrial). Doing so may save you time if similar development is underway and ensure that whatever approach you take is acceptable to the community of reviewers once it is submitted.

I assume that the ROS Discourse link went to the wrong place. Is this the correct link?

@gavanderhoorn
Copy link
Member

Same comments as on ros-industrial/abb_libegm#13.

@jontje
Copy link
Contributor

jontje commented Jun 14, 2019

Closing according to ros-industrial/abb_libegm#13 (comment).

@jontje jontje closed this Jun 14, 2019
@jontje jontje mentioned this pull request Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants