Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update axis.launch #31

Merged
merged 1 commit into from
Feb 6, 2015
Merged

Update axis.launch #31

merged 1 commit into from
Feb 6, 2015

Conversation

jeff-o
Copy link
Contributor

@jeff-o jeff-o commented Feb 6, 2015

Corrects an issue where a topic subscribes and publishes to the same node (axis/republish).

Corrects an issue where a topic subscribes and publishes to the same node (axis/republish).
@@ -15,7 +15,7 @@
<node pkg="image_transport" type="republish" name="republish"
args="compressed" if="$(arg enable_theora)">
<remap from="in" to="image_raw" />
<remap from="out" to="image_raw" />
<remap from="out" to="image_raw_out" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure this does the right thing?

I thought the issue was the compressed topic overlapping?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested it. Previously, if I did a rostopic info
/axis/image_raw/compressed, I saw axis/republish as both a subscriber and a
publisher. Now it doesn't do that. I can view both the compressed and
theora topics without issue.

I should note that this only crops up if you enable theora, which makes
sense.

On Fri, Feb 6, 2015 at 10:53 AM, Mike Purvis notifications@github.com
wrote:

In launch/axis.launch
#31 (comment)
:

@@ -15,7 +15,7 @@

  •  <remap from="out" to="image_raw" />
    
  •  <remap from="out" to="image_raw_out" />
    

Are you sure this does the right thing?

I thought the issue was the compressed topic overlapping?


Reply to this email directly or view it on GitHub
https://github.com/clearpathrobotics/axis_camera/pull/31/files#r24249096
.

Jeff Schmidt
System Integration Technologist
Clearpath Robotics
Phone: 519-513-2416

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, LGTM then.

mikepurvis added a commit that referenced this pull request Feb 6, 2015
@mikepurvis mikepurvis merged commit 6af88e9 into master Feb 6, 2015
@mikepurvis mikepurvis deleted the jeff-o-patch-1 branch February 6, 2015 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants