Remove redundant underscores before creating subdirectories #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well spotted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code introduced in commit d88da85 to (once again) collapse underscores in filenames seems to appear too late in the logic of the function, if subdirectories need to be created. In this case the uncollapsed directory name will be created, resulting in a subsequent failure to create files within the directory with the collapsed name, since it hasn't been created.
I've moved this logic slightly earlier in the function to resolve the issue. This seems to work correctly in my limited testing, but I may have missed some possible code-paths so it's worth double-checking the new placement.