Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test/impacket 0 9 20 #7

Open
wants to merge 71 commits into
base: master
Choose a base branch
from
Open

Test/impacket 0 9 20 #7

wants to merge 71 commits into from

Conversation

ropnop
Copy link
Owner

@ropnop ropnop commented Dec 15, 2019

No description provided.

cnotin and others added 30 commits April 3, 2019 16:22
Should the __python36__ branch be removed as well to keep folks from stumbling into the wrong place?
Travis CI: Time to take off the training wheels...
hLsarOpenPolicy2 was being reference (incorrectly) from lsat
flake8 says:
```
./impacket/examples/remcomsvc.py:1:1: E902 TokenError: EOF in multi-line statement
```
- Shown under Python3 (Python2 doesn't care)
- Addresses fortra/impacket#617
- Also fixed another minor Python2/3 dict port
__decryptHash was throwing IndexError on Windows 2016 if a hash was
encrypted with a PEK with a higher index than 0. This patch attempts to
extract all keys from the PEK list. The PEK list format was reverse
engineering by eyeball. YMMV.
Remove trailing backslash in remcomsvc.py
smb3: fix the check to not encrypt anonymous connection
This is a lazy change. Delete commented and unused lines.
Travis CI: Test on Python 3.7 and flake8 3.7
asolino and others added 30 commits June 15, 2019 10:44
Also handling raw buffers in dtypes.STR.__getitem__()
Adjust 5257b9d changes to dtypes.STR to work in Python 2 & 3
- Plus fixing bug that wasn't showing the domain we're connecting when using the NETLOGON approach to get signing keys
and for testing KDC handling S4U2Self with unkeyed checksum.

See CVE-2018-16860 and CVE-2019-0734

Signed-off-by: Isaac Boukris <iboukris@gmail.com>
- chmod +x
- Adding exec #!
- Adding impacket banner
- Fixing code style proposed by pyCharm
Added NTLM relays leveraging Webdav authentications
fix the import path of hLsarOpenPolicy2
Signed-off-by: Michael Niewöhner <michael.niewoehner@8com.de>
Signed-off-by: Michael Niewöhner <michael.niewoehner@8com.de>
Hi,

RQueryServiceObjectSecurity structure wasn't configured properly. The array of the actual security descriptor was defined as the whole response, so it wasn't able to unpack 'pcbBytesNeeded' properly. I fixed this and the handling of insufficient buffer size (cbBufSize is smaller than the size of the security descriptor).
Fix bug in RQueryServiceObjectSecurity
Hi,

in SMB2QueryInfo the infoType field was statically set to SMB2_0_INFO_FILE. In order to query security descriptor and more, I change it to use the actual infoType parameter passed to the function.
Add support for all info types query\set info request
- It'll just last a few minutes till we come back to -dev :P
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.