Bugfix husky eslint linting errors #29
Conversation
.eslintignore
Outdated
| @@ -0,0 +1 @@ | |||
| packages/ | |||
There was a problem hiding this comment.
but why? :D if there is no lint script specified the linter does not run in the first place...
I think we should also lint files in utils for example
There was a problem hiding this comment.
It's super weird, yesterday i wasn't able to commit any changes because of this, though today i saw that this error only happens if you change the corresponding package. The lint seems to be skipped for tonemato-utils if you just change an app.
Maybe yesterday pulling changes for this file or some formatting stuff triggered a lint? idk. Removing .eslintignore for now since this issue only occurs when modifying a package.
There was a problem hiding this comment.
Here a picture of what happens if you change tonemato-utils and try to commit.
There was a problem hiding this comment.
ahhhh I know why... thats my bad I configured lint-staged to check that package but never set up eslint there :D gonna add a fix for that in a separate pr
lel
Fixes #28
Solutions
no-unused-varso drilbur can lint, see: Node must be provided when reporting error if location is not provided prettier/eslint-plugin-prettier#306 (comment).eslintignore, so eslint does not try to lint unconfiguredpackages, see: Exclude paths lint-staged/lint-staged#123 (comment)yesterday.getDate() - 1.1toyesterday.getDate() - 1to widen the delta of the point in time being yesterday and checking ifnowis exactly one day ago.