-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reformat cas #398
Reformat cas #398
Conversation
affects behavior of bcpc, cts, etox, flavornet, pan, pubchem, srs. - changed the way names are assigned to lapply output because I ran into a problem with the way the output was being formatted for non-cas cas numbers like "balloon".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few problems that need fixing, but the concept is great.
Co-authored-by: Eric R. Scott <scottericr@gmail.com>
…nto reformat_cas
Thanks @ethanbass! Wondering if you folks want this to be part of the next release? I need to resubmit v1.3.0 to CRAN with some comments so I can wait until we merge this PR. |
Whatever you all want to do in this regard is fine with me. I'm not really familiar with your release schedule |
Do we want to add additional tests associated with this PR? |
Not sure why checks on ubuntu-20.04 (devel) passed before and do not pass now, maybe we should update GitHub actions? A possible lead here: https://community.rstudio.com/t/github-action-failure-with-rcmd-check-on-ubuntu-devel/129727. I'm going to merge this PR and fix the check afterwards. |
as.cas
in bcpc, cts, etox, flavornet, pan, pubchem, srs functions.verbose
argument toas.cas
.as.cas
so it returns a named character vector whose names are the character strings from the original query.as.cas
(since it now retains the names of the original query).lapply
output because I ran into a problem with the way the output was being formatted for "non-cas" cas numbers like "balloon".PR task list:
devtools::document()