Edits addressing rOpenSci peer review #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add rOpenSci badge - tweak datalake example
* migrate to ps-based service handling * namespace fn calls directly from ps in tests * merge all tests needing running vos into single location.
Merge branch 'master' into ropensci-review # Conflicts: # vignettes/articles/datalake.Rmd
25 tasks
|
rOpenSci revisions approved in ropensci/software-review#271 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses each of the issues raised by rOpenSci peer review so far. In particular, should hopefully resolve the Windows issues surfaced by @edgararuiz so far, and all the excellent suggestions raised by @czeildi (as detailed in #26).