Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- Use {pak} for pkg installation and binaries on Linux #327

Merged
merged 7 commits into from
Aug 28, 2022
Merged

- Use {pak} for pkg installation and binaries on Linux #327

merged 7 commits into from
Aug 28, 2022

Conversation

pat-s
Copy link
Member

@pat-s pat-s commented Aug 27, 2022

  • {pak} seems stable enough meanwhile to build on it
  • Binary pkgs are used on Linux and macOS in favor of source installs. A functioning toolchain for source installs is still provided and stays major feature
  • The switch to {pak} allowed to reduce many OS-specific parts in the YAML

This change will live in the default branch for some time for testing before templates are updated.

Changes

  • Replaced {remotes} with {pak} in all installation calls
  • Removed system lib dependency installation stages as {pak} is able to do so on its own - at least for the pkgs which have them listed in the DESCRIPTION file. Additional deps need to be installed in a custom block anyway
  • Removed global env var SDKROOT as the workaround is no longer needed
  • Removed global env var R_REMOTES_NO_ERRORS_FROM_WARNINGS as {remotes} is no longer used
  • Removed if condition on "after_success" stages as {covr} is triggered by the matrix item codecov: true|false
  • step_install_deps(), step_install_github(), step_install_cran(): remove arguments type and repo as {pak} does not use them

@pat-s pat-s marked this pull request as ready for review August 28, 2022 08:01
@pat-s
Copy link
Member Author

pat-s commented Aug 28, 2022

Existing YAMLs seem to work fine with the new approach, merging and testing.

@pat-s pat-s changed the title Use {pak} for pkg installation and binaries on Linux - Use {pak} for pkg installation and binaries on Linux Aug 28, 2022
@pat-s pat-s merged commit ab39338 into main Aug 28, 2022
@pat-s pat-s deleted the pak2 branch August 28, 2022 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant