Correct owner and repo in CLI message of gha_add_secret() #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you're in a project `owner/repoA` but adding a secret to another repository with `repo_slug = "owner/repoB"`, the CLI alert message will always report having added the secret to `owner/repoA`. Since `owner` and `repo` are already found at the start of the function, I changed the message to use those objects directly rather than calling `get_owner(remote)` etc again.
|
Thanks for the explanation and the time for submitting the patch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you're in a project
owner/repoAbut adding a secret to another repository withrepo_slug = "owner/repoB", the CLI alert message will always report having added the secret toowner/repoA.Since
ownerandrepoare already found at the start of the function, I changed the message to use those objects directly rather than callingget_owner(remote)etc again.