Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

- DSL: Don't add steps twice, if present in a previous macro #272

Merged
merged 5 commits into from
Jul 13, 2020
Merged

- DSL: Don't add steps twice, if present in a previous macro #272

merged 5 commits into from
Jul 13, 2020

Conversation

pat-s
Copy link
Member

@pat-s pat-s commented Jun 24, 2020

fixes #145

Only applies to fully identical duplicates.

@pat-s pat-s requested a review from krlmlr June 24, 2020 21:14
@pat-s
Copy link
Member Author

pat-s commented Jul 1, 2020

ping @krlmlr

1 similar comment
@pat-s
Copy link
Member Author

pat-s commented Jul 10, 2020

ping @krlmlr

@krlmlr
Copy link
Collaborator

krlmlr commented Jul 13, 2020

What happens if we add two steps with the same name but different arguments?

@pat-s
Copy link
Member Author

pat-s commented Jul 13, 2020

@krlmlr seems to work fine. Updated the test.

@pat-s pat-s changed the title DSL: Don't add steps twice, if present in a previous macro - DSL: Don't add steps twice, if present in a previous macro Jul 13, 2020
@pat-s pat-s merged commit 06bb1f2 into master Jul 13, 2020
@pat-s pat-s deleted the bugfix/145 branch July 13, 2020 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krlmlr krlmlr krlmlr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't add steps twice, if present in a previous macro
2 participants
@pat-s @krlmlr