Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add macro
do_drat()
#221Add macro
do_drat()
#221Changes from 17 commits
fb16d42
43952e8
ff245db
6a2583e
d599bcd
03c8917
3006dc5
c1aad3e
7ce717a
ef853b4
a98eca2
5f9cf13
2eb44ab
a28680f
81439e4
832bf47
7fb670e
a5d1c1c
f6613f5
c8ca8d7
567bb76
1714e5e
d3e7e00
0d4f695
67864df
983732e
6068a1c
b685f85
8430f15
80bcb57
826ba29
4e422ad
dbe32f2
f1434ca
1f68799
190aa97
63771ac
50f5df4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this still the correct default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case yes. We have to manually insert the private secured key in
appveyor.yml
and I think inserting it with "TRAVIS_DEPLOY_KEY" would be misleading.Since "id_rsa" is supported universally, I choose to go with it here.
Keys on Appveyor needs to be manually created anyway until now. We could change the name once we have an Appveyor client pkg.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't mind reverting to
"id_rsa"
, this would save lots of downstream pain.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, I know. One reason of the whole effort was to ensure that differently named private SSH key works throughout all functions, especially when installing the key. This came from the motivation to decouple
travis::use_travis_deploy()
from {tic}. I know that this does not mean that the default needs to change necessarily - but having a different one is an indirect way to save the tests whether a custom name would also work 😅Also I still think that some non-tech users will have an easier life understanding what that env var is about.
However, I see that we complicate things (a bit) since
id_rsa
is the canonical default picked up everywhere.Argh, I don't know what's best 🤔
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.