Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add detailed description for class2tree #851

Merged
merged 6 commits into from
Oct 12, 2020
Merged

add detailed description for class2tree #851

merged 6 commits into from
Oct 12, 2020

Conversation

trvinh
Copy link
Contributor

@trvinh trvinh commented Oct 8, 2020

Description

Add a detailed description for class2tree to explain how the function works

#' @details See [vegan::taxa2dist()]. Thanks to Jari Oksanen for
#' making the taxa2dist function and pointing it out, and Clarke & Warwick
#' (1998, 2001), which taxa2dist was based on.
#' The taxonomy tree created is not only based on the clustering of the taxonomy
#' ranks (e.g. strain, species, genus, ...), but it also utilizes the actual 
#' taxon clades (e.g. mammals, plants or reptiles, etc.). The process of this 
#' function is as following: First, all possible taxonomy ranks and their 
#' corresponding IDs for each given taxon will be collected from the input.
#' Then, the rank vectors of all taxa will be aligned, so that they together 
#' will become a matrix with columns are a list of ordered taxonomy ranks of all
#' given taxa and rows are the rank vectors of those taxa. After that, the rank
#' matrix will be converted into ID matrix, any missing rank will have a pseudo
#' ID from the previous rank. Finally, this ID matrix will be used to cluster
#' taxa that have similar taxonomy string together.

Related Issue

#849

Example

@trvinh trvinh requested a review from sckott October 8, 2020 10:36
@sckott sckott added this to the v0.9.99 milestone Oct 8, 2020
Copy link
Contributor

@sckott sckott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! some questions

trvinh and others added 2 commits October 10, 2020 17:56
… caused an error when an object was empty (#3)

bump version

add test for ncbi_downstream when no intermediate data returned

Co-authored-by: Scott Chamberlain <myrmecocystus@gmail.com>
@trvinh
Copy link
Contributor Author

trvinh commented Oct 10, 2020

@sckott can you please check again? I have changed all the points from your comments. I hope that it is ok now.

@sckott sckott merged commit bb6ed63 into ropensci:master Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants