Switch to secretbase::siphash13() #1262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wlandau-lilly
pushed a commit
to ropensci/tarchetypes
that referenced
this pull request
Apr 5, 2024
… the hashing functions from digest::digest() to secretbase::siphash13().
wlandau-lilly
added a commit
to ropensci/jagstargets
that referenced
this pull request
Apr 5, 2024
… the hashing functions from digest::digest() to secretbase::siphash13().
wlandau-lilly
added a commit
to ropensci/stantargets
that referenced
this pull request
Apr 5, 2024
… the hashing functions from digest::digest() to secretbase::siphash13().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prework
Related GitHub issues and pull requests
Summary
Invalidating changes
secretbase::siphash13()instead ofdigest(algo = "xxhash64", serializationVersion = 3)so hashes of in-memory objects no longer depend on serialization version 3 headers (Portability issue in hashes #1244, @shikokuchuo). Unfortunately, pipelines built with earlier versions oftargetswill need to rerun.Other improvements
targetsand changes to the package will cause the current work to rerun (Portability issue in hashes #1244). For thetar_make*()functions,utils::menu()prompts the user to give people a chance to downgrade if necessary.data.table::fread(), then convert them to the correct types afterwards.