Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Key setup #31

Merged
merged 3 commits into from
Jul 16, 2018
Merged

Key setup #31

merged 3 commits into from
Jul 16, 2018

Conversation

maelle
Copy link
Member

@maelle maelle commented Jul 16, 2018

Cf ropensci/taxize#693

I also added rOpenSci and myself in DESCRIPTION.

Many files were changed because of my using roxygen2 dev version... is this ok? 🤔

@maelle maelle requested a review from sckott July 16, 2018 10:45
@maelle
Copy link
Member Author

maelle commented Jul 16, 2018

Note that I wasn't able to knit README.Rmd myself because I haven't received my API key yet. 😿 (well I requested it today)

@maelle
Copy link
Member Author

maelle commented Jul 16, 2018

I needed to increment the version number for taxize DESCRIPTION but wasn't too sure how exactly, so the new number is probably wrong at the moment.

@sckott
Copy link
Contributor

sckott commented Jul 16, 2018

thanks , looks good!

@sckott sckott merged commit 9fa4f0f into ropensci:master Jul 16, 2018
@sckott sckott added this to the v0.5 milestone Jul 16, 2018
@maelle
Copy link
Member Author

maelle commented Jul 16, 2018

Thx. Can you knit the README?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sckott sckott sckott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.5
Development

Successfully merging this pull request may close these issues.
2 participants
@maelle @sckott