Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug from CRAN core #12

Closed
sckott opened this issue Feb 20, 2014 · 14 comments
Closed

Bug from CRAN core #12

sckott opened this issue Feb 20, 2014 · 14 comments
Labels
Milestone

Comments

@sckott
Copy link
Contributor

sckott commented Feb 20, 2014

Package: rebird Version: 0.1
Check: DESCRIPTION meta-information ... NOTE
Deprecated license: BSD

@sckott sckott added the Bug label Feb 20, 2014
@rmaia
Copy link
Member

rmaia commented Feb 20, 2014

yeah I got this email today. I notice that you guys have been working on the package a lot, so I don't want to jump ahead, change it and submit it if it's not ready for primetime. So let me know, I can either do anything that might be needed for the package, submit the current github version as is (after editing the license), or if I should change the last submitted commit and send that. Cheers!

@sckott sckott added this to the v0.2 milestone Feb 20, 2014
@sckott
Copy link
Contributor Author

sckott commented Feb 20, 2014

Can you/we work on the items in the 0.2 milestone and then push?

@sckott
Copy link
Contributor Author

sckott commented Feb 20, 2014

See #2 for changing license if you agree to go with MIT that is

@rmaia
Copy link
Member

rmaia commented Feb 20, 2014

sounds good, I'll try to get to all the milestone issues by tomorrow

@rmaia
Copy link
Member

rmaia commented Feb 24, 2014

maybe we have enough to close this milestone and send the version with the fixed license now, since there is a deadline, and work on the httr/rcurl thing for v0.3

@sckott
Copy link
Contributor Author

sckott commented Feb 24, 2014

Sure, that sounds good

@karthik
Copy link
Member

karthik commented Feb 24, 2014

@rmaia Yeah, go ahead. It passes all checks for now and should be good to go. We can easily help get the httr version completed before the end of the month.

@rmaia
Copy link
Member

rmaia commented Feb 28, 2014

so in wrapping up I got this note:

  • checking dependencies in R code ... NOTE
    Namespace in Imports field not imported from: 'assertthat'
    All declared Imports should be used.

I'm not sure what was changed that required / stopped requiring "assertthat", I think this just slipped in, but figured I'd check before removing it. Are any functions currently using it? Can I just remove?

@sckott
Copy link
Contributor Author

sckott commented Feb 28, 2014

I don't see assertthat functions anywhere in the package, so do remove

@karthik
Copy link
Member

karthik commented Feb 28, 2014

I'm likely the one that added it in the httr branch so that we use more assertions in the code. Good idea to remove now for submission. I'll put it back when we actually include it.

@rmaia
Copy link
Member

rmaia commented Mar 4, 2014

OK I'm having trouble building & releasing the package. winbuild went ok, but I think Mavericks messed something up on my xcode devtools.

when trying to build for release, I get the following error:

Checking rebird with devtools
Checking for any extra files in built .tar.gz file... sh: /usr/bin/gnutar: No such file or directory
Error in system(cmd, intern = TRUE) : error in running command

I tried following the instructions here but when I run xcode-select --install and it tries to install the development tools, it cancels halfway with the message:

Can't install the software because it is not currently available from the Software Update server

I tried waiting a couple days and from different connections (fearing it was my university firewall or something), but still, no luck. Any ideas?

@sckott
Copy link
Contributor Author

sckott commented Mar 4, 2014

hey @rmaia sorry about that. I had the same problem a while back with the release function. This worked for me r-lib/devtools#379 (comment) Let us know if that doesn't fix it

@karthik
Copy link
Member

karthik commented Mar 4, 2014

Yeah, weird it hasn't been fixed on devtools by now. I did the symbolic link too even though it is not the recommended way.

@rmaia
Copy link
Member

rmaia commented Mar 5, 2014

ok that worked, version 0.1.1 is on CRAN now

@rmaia rmaia closed this as completed Mar 5, 2014
sebpardo pushed a commit that referenced this issue Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants