Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add search works addin #152

Merged
merged 4 commits into from
Feb 22, 2018
Merged

add search works addin #152

merged 4 commits into from
Feb 22, 2018

Conversation

haozhu233
Copy link
Contributor

Per issue #148, I added a panel in the addin that allows users to search articles through cr_works. Please review.

Related Issue

#148

Example

screen shot 2018-02-22 at 10 38 37 am

@haozhu233
Copy link
Contributor Author

haozhu233 commented Feb 22, 2018

Note that right now I only provide the top 100 results. @sckott do you think it's enough? I guess People can always use the advanced search on the mainsite to find the correct DOI.

@sckott
Copy link
Contributor

sckott commented Feb 22, 2018

I guess People can always use the advanced search on the mainsite to find the correct DOI.

what do you mean by the main site?

@haozhu233
Copy link
Contributor Author

haozhu233 commented Feb 22, 2018

ha, I mean the the crossref site. As I said, for this addin, I only downloaded the first 100 results. I personally feel like that's enough for such an "addin". If people needs to go beyond 100 here, they probably should consider going to crossref.org and using the filtering tools over there.

@sckott
Copy link
Contributor

sckott commented Feb 22, 2018

okay, thanks. makes sense. i agree that 100 is enough

i'll have a look at it now

@haozhu233
Copy link
Contributor Author

I made another tiny change.

@sckott
Copy link
Contributor

sckott commented Feb 22, 2018

LGTM

@sckott sckott added this to the v0.8.4 milestone Feb 22, 2018
@sckott sckott merged commit e88e72f into ropensci:master Feb 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants