Share contact infos with Crossref #145

njahn82 · 2017-10-18T20:24:36Z

Following #144 this stores the email address in .Renviron and shares it with Crossref via the user agent

njahn82 · 2017-10-19T08:54:42Z

Sorry @sckott I messed it up again. Now tests are not failing because of missing email info in .Renviron

sckott · 2017-10-19T18:05:08Z

R/zzz.R

  url <- sprintf("https://api.crossref.org/%s", endpoint)
  cli <- crul::HttpClient$new(
    url = url,
+    opts = list(verbose = TRUE),


@njahn82 did you mean to leave this here?

sckott · 2017-10-19T18:06:19Z

thanks for this, a comment above.

also, i think in your original PR you had added some tests. can you do that?

njahn82 · 2017-10-23T11:20:51Z

Sorry for the delay, I added some tests, but not for all functions to keep run time of tests low. Hope I did not miss something

sckott · 2017-10-23T21:23:36Z

thanks much for doing this work!

njahn82 added 6 commits October 18, 2017 22:21

store email locally and optionally send it to crossref via header

9cd6c36

don't verbose api call

c815eac

test why travis test fails

21f5b92

remove custom library path

d0adfda

custom steps before install

aaab00f

😓 return NULL when no email address is stored in .Renviron

d5e34dd

sckott reviewed Oct 19, 2017

View reviewed changes

njahn82 added 2 commits October 20, 2017 17:10

remove verbose option

308f184

adding some tests

dd5ad2c

sckott added this to the v0.8 milestone Oct 23, 2017

sckott merged commit 1a41ed6 into ropensci:master Oct 23, 2017

sckott mentioned this pull request Dec 1, 2017

document option to include email address for Crossref queries ropensci-archive/fulltext#123

Closed

Provide feedback