Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added an "Add Crossref Citations" Rstudio addin #114

Merged
merged 5 commits into from
Jul 25, 2016
Merged

Added an "Add Crossref Citations" Rstudio addin #114

merged 5 commits into from
Jul 25, 2016

Conversation

haozhu233
Copy link
Contributor

Hi, Scott,

Following what I said in my email, I just made a draft of a Rstudio addin, that will save crossref citations to a local bib file. Please review it when you have time. :)

Screenshots:
screenshot 2016-07-22 10 22 58
screenshot 2016-07-22 10 23 08

Merge remote-tracking branch 'upstream/master'

# Conflicts:
#	DESCRIPTION
@codecov-io
Copy link

codecov-io commented Jul 22, 2016

Current coverage is 54.60% (diff: 0.00%)

Merging #114 into master will decrease coverage by 5.07%

@@             master       #114   diff @@
==========================================
  Files            26         27     +1   
  Lines          1173       1282   +109   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits            700        700          
- Misses          473        582   +109   
  Partials          0          0          

Powered by Codecov. Last update ddd11d1...28a22ba

@sckott
Copy link
Contributor

sckott commented Jul 22, 2016

Thanks, will have a look

@sckott
Copy link
Contributor

sckott commented Jul 22, 2016

@haozhu233 had a look:

  • can you possibly give the labels for each citation something related to the paper? e.g., I put in two DOIs 10.1002/(issn)1939-9170 and 10.4996/fireecology and the gave
@misc{1,
    doi = {10.1002/(issn)1939-9170},
    url = {http://dx.doi.org/10.1002/(issn)1939-9170},
    publisher = {Wiley-Blackwell},
    title = {Ecology}
}

@misc{1,
    doi = {10.4996/fireecology},
    url = {http://dx.doi.org/10.4996/fireecology},
    publisher = {Association for Fire Ecology},
    title = {Fire Ecology}
}

both labeled with 1 - I realize those two citations do not have author information, but perhaps they can be labeled uniquely somehow

  • I noticed when using the add when you do a 2nd or 3rd press of Add My Citations with a DOI you don't get the info printed as you do on the first, e.g., see below

screen shot 2016-07-22 at 4 09 15 pm

@haozhu233
Copy link
Contributor Author

haozhu233 commented Jul 24, 2016

@sckott Hi, Scott, I just made some changes to this PR to fulfill your feature request and fix that bug.

Now you will have the first word of the title as label if author is not available

@misc{Ecology,
    doi = {10.1002/(issn)1939-9170},
    url = {http://dx.doi.org/10.1002/(issn)1939-9170},
    publisher = {Wiley-Blackwell},
    title = {Ecology}
}

@misc{Fire,
    doi = {10.4996/fireecology},
    url = {http://dx.doi.org/10.4996/fireecology},
    publisher = {Association for Fire Ecology},
    title = {Fire Ecology}
}

@article{Notes_1907,
    doi = {10.2307/4070372},
    url = {http://dx.doi.org/10.2307/4070372},
    year = 1907,
    month = {jan},
    publisher = {{JSTOR}},
    volume = {24},
    number = {1},
    pages = {118--120},
    title = {Notes and News},
    journal = {The Auk}
}

I also fixed that bug that will disable the preview of 2nd (or later) entry. Please review. Thanks! :)

@sckott
Copy link
Contributor

sckott commented Jul 25, 2016

thanks, looks better, though on check I get

checking foreign function calls
N  checking R code for possible problems
   crAddins : server: no visible global function definition forreactiveValuesUndefined global functions or variables:
     reactiveValues

@haozhu233
Copy link
Contributor Author

Sorry, I forgot to add that to the NAMESPACE. Now it's in. :)

@sckott
Copy link
Contributor

sckott commented Jul 25, 2016

thanks!

@sckott sckott merged commit 438f647 into ropensci:master Jul 25, 2016
@sckott sckott added this to the v0.6 milestone Jul 25, 2016
@sckott sckott modified the milestones: v0.6, v0.5.8 Aug 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants