Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ".progress" option for deep pagination #186

Closed
Bubblbu opened this issue Apr 24, 2019 · 4 comments · Fixed by #188
Closed

Add ".progress" option for deep pagination #186

Bubblbu opened this issue Apr 24, 2019 · 4 comments · Fixed by #188
Milestone
v0.9.2

Comments

@Bubblbu
Copy link

Bubblbu commented Apr 24, 2019

I was wondering if it would be possible to add the option to display the plyr progress bar for deep pagination with the cursor="*" option. Currently, to my understanding, only lists of identifiers are supported.
@sckott
Copy link
Contributor

sckott commented Apr 25, 2019

thanks, i'll take a look.

@sckott sckott added this to the v1.0 milestone Apr 30, 2019
sckott added a commit that referenced this issue Apr 30, 2019
@sckott
#186 attempting progress bar for when cursor in use for deep paging
85c28eb
@sckott
Copy link
Contributor

sckott commented Apr 30, 2019

@Bubblbu okay, made a change, try

remotes::install_github("ropensci/rcrossref@cursor-progress")
library(rcrossref)
cr_works(query="NSF", cursor = "*", cursor_max = 120, limit = 30, .progress = TRUE)

@Bubblbu
Copy link
Author

Bubblbu commented May 1, 2019

works like a charm. awesome!

thanks!

@Bubblbu Bubblbu closed this as completed May 1, 2019
@sckott
Copy link
Contributor

sckott commented May 1, 2019

great, glad it works

@sckott sckott modified the milestones: v1.0, v0.9.2 May 3, 2019
sckott added a commit that referenced this issue May 3, 2019
@sckott
#186 add code and tests for remainder of core crossref cr_* fxns for …
99a1007 
…progress bars for works=TRUE
sckott added a commit that referenced this issue May 3, 2019
@sckott
update man files #186
2864d71
@sckott sckott mentioned this issue May 3, 2019
Merged
sckott added a commit that referenced this issue May 3, 2019
@sckott
Cursor progress bars (#188)
39e137a 
* #186 attempting progress bar for when cursor in use for deep paging

* #186  add code and tests for remainder of core crossref cr_* fxns for progress bars for works=TRUE

* update man files #186
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.9.2
Development

Successfully merging a pull request may close this issue.

Cursor progress bars ropensci/rcrossref
2 participants
@sckott @Bubblbu