tweak some egs, fix a bug in cr_journals for facet parsing

ropensci · May 3, 2019 · cb87db0 · cb87db0
1 parent e4e1e34
commit cb87db0
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 7 deletions.
diff --git a/R/cr_journals.r b/R/cr_journals.r
@@ -60,8 +60,8 @@
 #' cr_journals(c('1932-6203', '0028-0836'), works = TRUE, cursor = "*",
 #'    cursor_max = 300, limit = 100)
 #' ## with optional progress bar
-#' cr_journals(issn='1932-6203', works = TRUE, cursor = "*", cursor_max = 500,
-#'    limit = 100, .progress = TRUE)
+#' cr_journals(issn='1932-6203', works = TRUE, cursor = "*", cursor_max = 90,
+#'    limit = 30, .progress = TRUE)
 #'
 #' # fails, if you want works, you must give an ISSN
 #' # cr_journals(query = "ecology", filter=c(has_full_text = TRUE),
@@ -137,7 +137,7 @@
       } else {
         stats::setNames(facets,
           vapply(res2, function(z) {
-            if ("issn" %in% names(z)) z[['issn']][[1]] else z$items[[1]]$issn[[1]]
+            if ("issn" %in% names(z)) z[['issn']][[1]] else z$items[[1]]$issn[[1]]$value
           }, "")
         )
       }

diff --git a/R/id_converter.R b/R/id_converter.R
@@ -18,7 +18,6 @@
 #' # pmcid to doi/pmid
 #' id_converter("PMC2883744", "pmcid")
 #' id_converter("PMC2883744")
-#' id_converter("PMC2883744", "doi")
 #' 
 #' # manuscript id
 #' id_converter("NIHMS311352")

diff --git a/man/cr_journals.Rd b/man/cr_journals.Rd
diff --git a/man/id_converter.Rd b/man/id_converter.Rd