Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change interpretation of the jobs argument? #553

Closed
wlandau opened this issue Oct 18, 2018 · 4 comments
Closed

Change interpretation of the jobs argument? #553

wlandau opened this issue Oct 18, 2018 · 4 comments
Assignees

Comments

@wlandau
Copy link
Member

wlandau commented Oct 18, 2018

From #435 (comment), I am starting to think make(jobs = 16) should be equivalent to make(jobs = c(imports = 1, targets = 16)) rather than the current make(jobs = c(imports = 16, targets = 16)). What do you think? cc @kendonB, @idavydov.

@wlandau
Copy link
Member Author

wlandau commented Oct 18, 2018

Should be a simple matter of changing this line in parse_jobs() and updating this documentation.

@idavydov
Copy link

In my opinion that would be a good pragmatical decision.

  1. In case of small plans, this should not affect the performance significantly.
  2. For the large plans with a large number of jobs this should provide significant benefit (see Huge overhead in adjacent_vertices in a moderately sized project #435 (comment)).
  3. The only case when this could make things worse is a huge plan with the moderate number of workers (e.g. 1k targets, 5 jobs).

But I think cases when imports are the bottleneck should not be common.

wlandau-lilly added a commit that referenced this issue Oct 18, 2018
@wlandau
Copy link
Member Author

wlandau commented Oct 18, 2018

Yeah, I agree. And the decision is much easier now that version >= 6.0.0 has far fewer imports (ref: #519).

@wlandau
Copy link
Member Author

wlandau commented Oct 18, 2018

Edit: please see b786fe3.100c71f has a bug.

wlandau-lilly added a commit that referenced this issue Oct 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants