-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change interpretation of the jobs argument? #553
Labels
Comments
Should be a simple matter of changing this line in |
In my opinion that would be a good pragmatical decision.
But I think cases when imports are the bottleneck should not be common. |
Yeah, I agree. And the decision is much easier now that version >= 6.0.0 has far fewer imports (ref: #519). |
wlandau-lilly
added a commit
that referenced
this issue
Oct 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
From #435 (comment), I am starting to think
make(jobs = 16)
should be equivalent tomake(jobs = c(imports = 1, targets = 16))
rather than the currentmake(jobs = c(imports = 16, targets = 16))
. What do you think? cc @kendonB, @idavydov.The text was updated successfully, but these errors were encountered: