[bugfix] in adjust vertices

DESCRIPTION

@@ -1,7 +1,7 @@
 Package: Rpolyhedra
 Type: Package
 Title: Polyhedra Database
-Version: 0.5.5
+Version: 0.5.6
 Language: en-US
 Authors@R: c(
   person("Alejandro", "Baranek",,"abaranek@dc.uba.ar", c("aut","com","cre", "cph")),

NEWS.md

@@ -1,3 +1,8 @@
+Rpolyhedra 0.5.6
+============
+### MINOR IMPROVEMENTS
+* BUGFIX when vertices in solid but not defined
+
 Rpolyhedra 0.5.5
 ============
 ### MINOR IMPROVEMENTS

R/polyhedra-lib.R

@@ -806,16 +806,14 @@ PolyhedronStateDefined <- R6::R6Class(
     adjustVertices = function(normalize.size = TRUE) {
       logger <- getLogger(self)
       private$vertices.id.3d <- sort(unique(unlist(self$solid)))
-      vertices.id <- seq_len(nrow(self$vertices))
-      if (!identical(private$vertices.id.3d, vertices.id))
+      vertices.real <- seq_len(nrow(self$vertices))
+      vertices.missing <- setdiff(private$vertices.id.3d, vertices.real)
+      if (length(vertices.missing) > 0)
       {
-        solid.not.vertices <- setdiff(private$vertices.id.3d, vertices.id)
-        vertices.not.solid <- setdiff(vertices.id, private$vertices.id.3d)
-        logger$warn("Differences in solid than in vertices",
-                    missing.solid = solid.not.vertices,
-                    missing.vertices = vertices.not.solid)
+        logger$warn("Verticea in solid not defined",
+                    vertices.missing = vertices.missing)
       }
-      private$vertices.id.3d <- intersect(private$vertices.id.3d, vertices.id)
+      private$vertices.id.3d <- intersect(private$vertices.id.3d, vertices.real)
       self$vertices.centered <- self$vertices
       #browser()
       mass.center <- self$calculateMassCenter(

codemeta.json

@@ -4,11 +4,11 @@
   "identifier": "Rpolyhedra",
   "description": "A polyhedra database scraped from various sources as R6 objects and 'rgl' visualizing capabilities.",
   "name": "Rpolyhedra: Polyhedra Database",
-  "relatedLink": ["https://docs.ropensci.org/Rpolyhedra/", "https://CRAN.R-project.org/package=Rpolyhedra"],
+  "relatedLink": "https://docs.ropensci.org/Rpolyhedra/",
   "codeRepository": "https://github.com/ropensci/Rpolyhedra",
   "issueTracker": "https://github.com/ropensci/Rpolyhedra/issues",
   "license": "https://spdx.org/licenses/MIT",
-  "version": "0.5.5",
+  "version": "0.5.6",
   "programmingLanguage": {
     "@type": "ComputerLanguage",
     "name": "R",
@@ -267,15 +267,5 @@
     },
     "SystemRequirements": null
   },
-  "fileSize": "2229.903KB",
-  "releaseNotes": "https://github.com/ropensci/Rpolyhedra/blob/master/NEWS.md",
-  "readme": "https://github.com/ropensci/Rpolyhedra/blob/master/README.md",
-  "contIntegration": ["https://github.com/ropensci/Rpolyhedra/actions", "https://app.codecov.io/gh/ropensci/Rpolyhedra"],
-  "developmentStatus": "https://www.repostatus.org/#active",
-  "review": {
-    "@type": "Review",
-    "url": "https://github.com/ropensci/software-review/issues/157",
-    "provider": "https://ropensci.org"
-  },
-  "keywords": ["polyhedra-database", "geometry", "rgl"]
+  "fileSize": "2231.762KB"
 }

inst/extdata/version

@@ -1 +1 @@
-0.5.5
+0.5.6