Skip to content
This repository has been archived by the owner on May 30, 2022. It is now read-only.

Return both ISSNs #54

Closed
ciakovx opened this issue Sep 25, 2019 · 5 comments · Fixed by #55
Closed

Return both ISSNs #54

ciakovx opened this issue Sep 25, 2019 · 5 comments · Fixed by #55
Labels
bug Something isn't working

Comments

@ciakovx
Copy link

ciakovx commented Sep 25, 2019

Session Info
- Session info --------------------------------------------------------
 setting  value                       
 version  R version 3.6.0 (2019-04-26)
 os       Windows 10 x64              
 system   x86_64, mingw32             
 ui       RStudio                     
 language (EN)                        
 collate  English_United States.1252  
 ctype    English_United States.1252  
 tz       America/Chicago             
 date     2019-09-25                  

- Packages ------------------------------------------------------------
 package     * version date       lib source        
 assertthat    0.2.1   2019-03-21 [1] CRAN (R 3.6.0)
 backports     1.1.4   2019-04-10 [1] CRAN (R 3.6.0)
 bibtex        0.4.2   2017-06-30 [1] CRAN (R 3.6.0)
 broom         0.5.2   2019-04-07 [1] CRAN (R 3.6.0)
 callr         3.2.0   2019-03-15 [1] CRAN (R 3.6.0)
 cellranger    1.1.0   2016-07-27 [1] CRAN (R 3.6.0)
 cli           1.1.0   2019-03-19 [1] CRAN (R 3.6.0)
 colorspace    1.4-1   2019-03-18 [1] CRAN (R 3.6.0)
 crayon        1.3.4   2017-09-16 [1] CRAN (R 3.6.0)
 crul          0.7.4   2019-03-28 [1] CRAN (R 3.6.0)
 curl          3.3     2019-01-10 [1] CRAN (R 3.6.0)
 desc          1.2.0   2018-05-01 [1] CRAN (R 3.6.0)
 devtools      2.1.0   2019-07-06 [1] CRAN (R 3.6.1)
 digest        0.6.19  2019-05-20 [1] CRAN (R 3.6.0)
 dplyr       * 0.8.1   2019-05-14 [1] CRAN (R 3.6.0)
 DT            0.7     2019-06-11 [1] CRAN (R 3.6.0)
 fansi         0.4.0   2018-10-05 [1] CRAN (R 3.6.0)
 forcats     * 0.4.0   2019-02-17 [1] CRAN (R 3.6.0)
 fs            1.3.1   2019-05-06 [1] CRAN (R 3.6.0)
 generics      0.0.2   2018-11-29 [1] CRAN (R 3.6.0)
 ggplot2     * 3.2.0   2019-06-16 [1] CRAN (R 3.6.0)
 glue          1.3.1   2019-03-12 [1] CRAN (R 3.6.0)
 gtable        0.3.0   2019-03-25 [1] CRAN (R 3.6.0)
 haven         2.1.0   2019-02-19 [1] CRAN (R 3.6.0)
 hms           0.4.2   2018-03-10 [1] CRAN (R 3.6.0)
 htmltools     0.3.6   2017-04-28 [1] CRAN (R 3.6.0)
 htmlwidgets   1.3     2018-09-30 [1] CRAN (R 3.6.0)
 httpcode      0.2.0   2016-11-14 [1] CRAN (R 3.6.0)
 httpuv        1.5.1   2019-04-05 [1] CRAN (R 3.6.0)
 httr          1.4.0   2018-12-11 [1] CRAN (R 3.6.0)
 jsonlite      1.6     2018-12-07 [1] CRAN (R 3.6.0)
 later         0.8.0   2019-02-11 [1] CRAN (R 3.6.0)
 lattice       0.20-38 2018-11-04 [1] CRAN (R 3.6.0)
 lazyeval      0.2.2   2019-03-15 [1] CRAN (R 3.6.0)
 lubridate     1.7.4   2018-04-11 [1] CRAN (R 3.6.0)
 magrittr      1.5     2014-11-22 [1] CRAN (R 3.6.0)
 memoise       1.1.0   2017-04-21 [1] CRAN (R 3.6.1)
 mime          0.7     2019-06-11 [1] CRAN (R 3.6.0)
 miniUI        0.1.1.1 2018-05-18 [1] CRAN (R 3.6.0)
 modelr        0.1.4   2019-02-18 [1] CRAN (R 3.6.0)
 munsell       0.5.0   2018-06-12 [1] CRAN (R 3.6.0)
 nlme          3.1-139 2019-04-09 [1] CRAN (R 3.6.0)
 pillar        1.4.1   2019-05-28 [1] CRAN (R 3.6.0)
 pkgbuild      1.0.3   2019-03-20 [1] CRAN (R 3.6.1)
 pkgconfig     2.0.2   2018-08-16 [1] CRAN (R 3.6.0)
 pkgload       1.0.2   2018-10-29 [1] CRAN (R 3.6.1)
 plyr          1.8.4   2016-06-08 [1] CRAN (R 3.6.0)
 prettyunits   1.0.2   2015-07-13 [1] CRAN (R 3.6.0)
 processx      3.3.1   2019-05-08 [1] CRAN (R 3.6.0)
 promises      1.0.1   2018-04-13 [1] CRAN (R 3.6.0)
 ps            1.3.0   2018-12-21 [1] CRAN (R 3.6.0)
 purrr       * 0.3.2   2019-03-15 [1] CRAN (R 3.6.0)
 R.cache       0.13.0  2018-01-04 [1] CRAN (R 3.6.1)
 R.methodsS3   1.7.1   2016-02-16 [1] CRAN (R 3.6.0)
 R.oo          1.22.0  2018-04-22 [1] CRAN (R 3.6.0)
 R.utils       2.9.0   2019-06-13 [1] CRAN (R 3.6.1)
 R6            2.4.0   2019-02-14 [1] CRAN (R 3.6.0)
 Rcpp          1.0.1   2019-03-17 [1] CRAN (R 3.6.0)
 rcrossref   * 0.9.2   2019-05-04 [1] CRAN (R 3.6.0)
 readr       * 1.3.1   2018-12-21 [1] CRAN (R 3.6.0)
 readxl        1.3.1   2019-03-13 [1] CRAN (R 3.6.0)
 remotes       2.1.0   2019-06-24 [1] CRAN (R 3.6.1)
 rlang         0.3.4   2019-04-07 [1] CRAN (R 3.6.0)
 roadoi      * 0.5.2   2018-08-07 [1] CRAN (R 3.6.0)
 rprojroot     1.3-2   2018-01-03 [1] CRAN (R 3.6.0)
 rromeo      * 0.1.0   2019-05-16 [1] CRAN (R 3.6.1)
 rscopus     * 0.6.3   2018-11-19 [1] CRAN (R 3.6.0)
 rstudioapi    0.10    2019-03-19 [1] CRAN (R 3.6.0)
 rvest         0.3.4   2019-05-15 [1] CRAN (R 3.6.0)
 scales        1.0.0   2018-08-09 [1] CRAN (R 3.6.0)
 scholar     * 0.1.7   2018-07-03 [1] CRAN (R 3.6.1)
 selectr       0.4-1   2018-04-06 [1] CRAN (R 3.6.0)
 sessioninfo   1.1.1   2018-11-05 [1] CRAN (R 3.6.1)
 shiny         1.3.2   2019-04-22 [1] CRAN (R 3.6.1)
 stringi       1.4.3   2019-03-12 [1] CRAN (R 3.6.0)
 stringr     * 1.4.0   2019-02-10 [1] CRAN (R 3.6.0)
 testthat      2.1.1   2019-04-23 [1] CRAN (R 3.6.1)
 tibble      * 2.1.3   2019-06-06 [1] CRAN (R 3.6.0)
 tidyr       * 0.8.3   2019-03-01 [1] CRAN (R 3.6.0)
 tidyselect    0.2.5   2018-10-11 [1] CRAN (R 3.6.0)
 tidyverse   * 1.2.1   2017-11-14 [1] CRAN (R 3.6.0)
 triebeard     0.3.0   2016-08-04 [1] CRAN (R 3.6.0)
 urltools      1.7.3   2019-04-14 [1] CRAN (R 3.6.0)
 usethis       1.5.0   2019-04-07 [1] CRAN (R 3.6.0)
 utf8          1.1.4   2018-05-24 [1] CRAN (R 3.6.0)
 vctrs         0.1.0   2018-11-29 [1] CRAN (R 3.6.0)
 withr         2.1.2   2018-03-15 [1] CRAN (R 3.6.0)
 xml2          1.2.0   2018-01-24 [1] CRAN (R 3.6.0)
 xtable        1.8-4   2019-04-21 [1] CRAN (R 3.6.0)
 zeallot       0.1.0   2018-01-28 [1] CRAN (R 3.6.0)

Hi, thanks for your great work on this package, I'm finding it immensely helpful.

The data returned from the rr_journal_issn only includes a single ISSN field. Sometimes the returned ISSN does not match the ISSN used in the query. It would be helpful to include the ISSN used in the initial query, or both ISSNs, as I am joining the results to my original dataset according to the issn used in the query. An example:

> x <- rr_journal_issn("1463-9084")
> x$issn
[1] "1463-9076"
@Rekyt
Copy link
Collaborator

Rekyt commented Sep 27, 2019

Hi @ciakovx 👋 ,
Thank you for your interest in the package!

Indeed, sometimes several ISSNs are associated with the same journal for electronic and paper versions. The first version of SHERPA/RoMEO API was not really clear about this. But it should be fairly easy to add a column that uses the ISSNs provided by the user.
I'll be fixing this in the coming days.

By the way, SHERPA/RoMEO is deeply changing and a version 2 is currently accessible to developers. More data will be accessible through it and we are currently working on a way to organize and convey all these data to users with the easiest interface possible. The package will undergo major changes to account for these changes in the data structure.
So if you would like to access specific data, please do open new issues to suggest new features !

@ciakovx
Copy link
Author

ciakovx commented Sep 29, 2019 via email

@Rekyt
Copy link
Collaborator

Rekyt commented Sep 30, 2019

By the way Clarke, I forgot to mention that rOpenSci is collecting use cases on the packages that are part of it. We would be really interested if you would like to write a short post in the dedicated section of the forum on the way you use rromeo in your job and if you agree, a typical script that you use.

Thank you so much for your interest!
Matthias

@Rekyt Rekyt added the bug Something isn't working label Sep 30, 2019
@Rekyt Rekyt closed this as completed in #55 Sep 30, 2019
Rekyt pushed a commit that referenced this issue Sep 30, 2019
Fix #54 add provided ISSNs to output
@Rekyt
Copy link
Collaborator

Rekyt commented Sep 30, 2019

Hi Clarke @ciakovx, if you install the last development version of rromeo through remotes::install_github("ropensci/rromeo") there will be a new column called provided_issn that should let you merge your dataset properly.

@ciakovx
Copy link
Author

ciakovx commented Oct 8, 2019 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants