Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update devise token auth reference #85

Merged
merged 1 commit into from
Sep 19, 2017
Merged

Update devise token auth reference #85

merged 1 commit into from
Sep 19, 2017

Conversation

diebarral
Copy link
Contributor

This PR contains:

  • Update on the Gemfile to reference to our fork of devise token auth instead of the gem.
  • Testing for the exceptional case in which the tokens are stored as a string in the database.

@MaicolBen
Copy link
Contributor

@diebarral Squash the commits

@matiasmansilla1989
Copy link
Contributor

matiasmansilla1989 commented Sep 14, 2017 •
edited
Loading

@diebarral Great PR, my only concern is Why do we have 3 commits?

@diebarral
Copy link
Contributor Author

@matiasmansilla1989 I'll squash them

@diebarral diebarral force-pushed the fix/devise_token_auth_issue branch 3 times, most recently from b114401 to c0bb2bb Compare September 19, 2017 19:23
@diebarral diebarral force-pushed the fix/devise_token_auth_issue branch from c0bb2bb to 433a5aa Compare September 19, 2017 19:36
@MaicolBen MaicolBen merged commit 1ce6d3a into master Sep 19, 2017
@MaicolBen MaicolBen deleted the fix/devise_token_auth_issue branch September 19, 2017 19:41
@MaicolBen MaicolBen mentioned this pull request Sep 19, 2017
Closed
@zachfeldman zachfeldman mentioned this pull request Dec 26, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@santiagovidal santiagovidal santiagovidal approved these changes

@MaicolBen MaicolBen MaicolBen approved these changes

@GAKINDUSTRIES GAKINDUSTRIES Awaiting requested review from GAKINDUSTRIES

@matiasmansilla1989 matiasmansilla1989 Awaiting requested review from matiasmansilla1989

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@diebarral @MaicolBen @matiasmansilla1989 @santiagovidal