Added rspec, factory girl, faker and database cleanner #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaicolBen
force-pushed
the
add-rspec
branch
10 times, most recently
from
d1a2927 to
55a67b0
Compare
| describe FactoryGirl do | ||
| FactoryGirl.factories.map(&:name).each do |factory_name| | ||
| describe "The #{factory_name} factory" do | ||
| it 'is valid' do |
There was a problem hiding this comment.
Why do you prefer to have a custom message instead of it { expect(FactoryGirl.build(factory_name)).to be_valid }. Do you want to be consistent with the messages?
There was a problem hiding this comment.
I didn't realize about that, I'll change it
There was a problem hiding this comment.
I like it this way. I prefer to set the messages myself.
Maru321
reviewed
Oct 18, 2016
| describe FactoryGirl do | ||
| FactoryGirl.factories.map(&:name).each do |factory_name| | ||
| describe "The #{factory_name} factory" do | ||
| it 'is valid' do |
There was a problem hiding this comment.
I like it this way. I prefer to set the messages myself.
| @@ -0,0 +1,7 @@ | |||
| FactoryGirl.define do | |||
| factory :user, class: 'User' do | |||
|
|
||
| require 'spec_helper' | ||
|
|
||
| RSpec.describe User do |
There was a problem hiding this comment.
It didn't work in circle CI, I'll check again
Maru321
approved these changes
Oct 18, 2016
MaicolBen
force-pushed
the
add-rspec
branch
3 times, most recently
from
3178038 to
ee5ea59
Compare
santiagovidal
approved these changes
Oct 19, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure to include all the rspec config commented as an example