Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove refactor tag and fix rspec test #74

Merged
merged 1 commit into from
Sep 7, 2017
Merged

remove refactor tag and fix rspec test #74

merged 1 commit into from
Sep 7, 2017

Conversation

GuilleLeopold
Copy link
Contributor

@GuilleLeopold GuilleLeopold commented Aug 18, 2017 •
edited by MaicolBen
Loading

This PR was intended to solve this issue: #30

As the issue wasn't exactly the same as described, it wasn't necessary to make any changes in the client field.

Resolves: #30

@GuilleLeopold GuilleLeopold changed the title remove refactor label and fix rspec test remove refactor tag and fix rspec test Aug 18, 2017
MaicolBen
MaicolBen approved these changes Aug 18, 2017
View reviewed changes
Copy link
Contributor

@MaicolBen MaicolBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would create a issue in the devise token auth gem

@GAKINDUSTRIES GAKINDUSTRIES merged commit 0d084ce into master Sep 7, 2017
@MaicolBen MaicolBen deleted the fix_rspec_password branch September 7, 2017 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GAKINDUSTRIES GAKINDUSTRIES GAKINDUSTRIES approved these changes

@MaicolBen MaicolBen MaicolBen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GuilleLeopold @MaicolBen @GAKINDUSTRIES