Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added 500 handler & make facebook webmock more flexible #58

Merged
merged 1 commit into from
Jun 19, 2017
Merged

Added 500 handler & make facebook webmock more flexible #58

merged 1 commit into from
Jun 19, 2017

Conversation

MaicolBen
Copy link
Contributor

This PR includes:

  • Update company name in the api doc
  • Handle 500 error, let me know if you don't agree with this change
  • Make facebook webmock more flexible in case of adding params in the path

santiagovidal
santiagovidal approved these changes Jun 19, 2017
View reviewed changes
Copy link
Contributor

@santiagovidal santiagovidal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@matiasmansilla1989 matiasmansilla1989 merged commit ad3bc75 into master Jun 19, 2017
@matiasmansilla1989 matiasmansilla1989 deleted the minor-changes branch June 19, 2017 18:01
@MaicolBen MaicolBen mentioned this pull request Jun 20, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@santiagovidal santiagovidal santiagovidal approved these changes

@matiasmansilla1989 matiasmansilla1989 matiasmansilla1989 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MaicolBen @matiasmansilla1989 @santiagovidal