Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added devise #5

Merged
merged 1 commit into from
Oct 12, 2016
Merged

Added devise #5

merged 1 commit into from
Oct 12, 2016

Conversation

MaicolBen
Copy link
Contributor

@MaicolBen MaicolBen commented Oct 11, 2016 •
edited
Loading

This PR includes:

  • Added devise, it only includes the configuration (in next PRs I'll include the logic for sign in/sign up). I tested if it works in the browser
  • Added the read ENV variables code
  • Improved git ignore
  • Added middlewares to get html work in rails 5 api mode, in the readme file I added to check that configuration if your application will have a web app with assets, but is it worth to have api mode? More info: https://www.reddit.com/r/rails/comments/3vayy6/can_activeadmin_be_used_with_rails_api/
  • The user table has first_name, last_name and username added to the original device model. Is username useful?
  • Removed test folder, we'll use rspec in the future

@MaicolBen MaicolBen force-pushed the add-devise branch 2 times, most recently from 6c4fcad to 0a08fa5 Compare October 11, 2016 21:19
@MaicolBen
Copy link
Contributor Author

UPDATE: I removed api mode due to not add up much if some middlewares are added manually, also it'll be depend on the project.

matiasmansilla1989
matiasmansilla1989 reviewed Oct 12, 2016
View reviewed changes
README.md
@@ -3,9 +3,10 @@
## Setup

1. Clone this repo
2. Create your `database.yml` file
2. Create your `database.yml` and `application.yml` file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can add a third step "Generate a secret key rake secret and paste this value into the application.yml"
Does it make sense?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed

matiasmansilla1989
matiasmansilla1989 reviewed Oct 12, 2016
View reviewed changes
config/initializers/env_variables.rb
@@ -0,0 +1,5 @@
begin
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this code here instead of the application.rb

@matiasmansilla1989 matiasmansilla1989 merged commit feebd21 into master Oct 12, 2016
@MaicolBen MaicolBen deleted the add-devise branch December 1, 2016 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matiasmansilla1989 matiasmansilla1989 matiasmansilla1989 left review comments

@santiagovidal santiagovidal santiagovidal approved these changes

@jiv jiv jiv approved these changes

Assignees

@jiv jiv

@matiasmansilla1989 matiasmansilla1989

@adicaff adicaff

@santiagovidal santiagovidal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MaicolBen @jiv @matiasmansilla1989 @santiagovidal @adicaff