Migrate controller test to request/routing tests #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaicolBen
force-pushed
the
feature/migrate-to-request-specs
branch
2 times, most recently
from
3ffe528 to
129f367
Compare
|
|
||
| context 'with an user having the same email' do | ||
| before do | ||
| FactoryGirl.create :user, email: 'test@facebook.com' |
There was a problem hiding this comment.
is FactoryGirl necessary?
|
@MaicolBen Excellent job !!!! |
MaicolBen
force-pushed
the
feature/migrate-to-request-specs
branch
from
129f367 to
3e0217b
Compare
adicaff
approved these changes
Mar 23, 2017
| username: user.username, | ||
| uid: user.email, | ||
| provider: 'email', | ||
| first_name: user.first_name, |
There was a problem hiding this comment.
I'd like to align this assignations and some others similar in others files. But is your call.
MaicolBen
force-pushed
the
feature/migrate-to-request-specs
branch
from
3e0217b to
c6c9771
Compare
matiasmansilla1989
approved these changes
Apr 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #45
Skipped json content type control in edit password because it isn't a json request, read the 4th step of https://github.com/lynndylanhurley/devise_token_auth/wiki/Reset-Password-Flow
Now with the content type control, every test needs
as: :json, more info: http://api.rubyonrails.org/classes/ActionDispatch/IntegrationTest.html