Add examples, mermaid diagram and exit step #6
Conversation
PerezIgnacio
force-pushed
the
add-workflow-rendering
branch
from
8dcb2d7 to
730e27b
Compare
lib/mars/renderer.rb
Outdated
| # frozen_string_literal: true | ||
|
|
||
| module Mars | ||
| class Renderer |
There was a problem hiding this comment.
I think this class should be part of the Rendering module/package. Also not sure if it makes sense to have a to_mermaid method here, we could have different renderers.. so either this class needs to be more specific, or it shouldn't know about mermaid I guess
There was a problem hiding this comment.
maybe it should be Mars::Rendering::Mermaid::Renderer ?
There was a problem hiding this comment.
Makes sense. I've moved this logic to the Rendering::Mermaid module. My goal is to keep this as a single interface for rendering logic, without callers requiring to reference the Rendering::Mermaid:: components directly, which should stay internal to the renderer. The Mars::Renderer would now only be a sort of facade which defines a different interface, so I've removed it for now.
No description provided.