-
-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ubuntu 18.04 #992
Ubuntu 18.04 #992
Conversation
roles/mariadb/defaults/main.yml
Outdated
@@ -1,6 +1,6 @@ | |||
mariadb_keyserver: keyserver.ubuntu.com | |||
mariadb_keyserver: "hkp://keyserver.ubuntu.com:80" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not hkps://
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just copied from Mariadb site but updated to hkps
and it works 👍
I'm not sure there's a good seamless upgrade path here. In the past I think we just merged changes like this and people worked around it? The validation definitely makes it harder to deal with though. If someone is running 16.04 on a server and they pull the latest Trellis updates, they can't really use Trellis at all without modifications or upgrading to 18.04. @fullyint any thoughts? |
Turns out that Python 3 is the default on 18.04 which causes problems with Trellis/Ansible right now. Default Trellis behaviour is to let Vagrant install Ansible on the VM (this also applies to Windows usage).
|
vagrant.default.yml
Outdated
@@ -2,7 +2,7 @@ | |||
vagrant_ip: '192.168.50.5' | |||
vagrant_cpus: 1 | |||
vagrant_memory: 1024 # in MB | |||
vagrant_box: 'bento/ubuntu-16.04' | |||
vagrant_box: 'bento/ubuntu-18.04' | |||
vagrant_box_version: '>= 201801.02.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like bento/ubuntu-18.04
is first added on 201803.24.0
. Do we need to bump vagrant_box_version
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already updated to 201807.12.0 (18.04.1 Released)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated it to the latest 👍
mariadb_keyserver_id: "0xF1656F24C74CD1D8" | ||
mariadb_ppa: "deb [arch=amd64,i386,ppc64el] http://ftp.osuosl.org/pub/mariadb/repo/10.2/ubuntu xenial main" | ||
mariadb_ppa: "deb [arch=amd64] http://nyc2.mirrors.digitalocean.com/mariadb/repo/10.2/ubuntu {{ ansible_distribution_release }} main" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Python 3 support is being worked on in #1031 |
22aebef
to
2acec4a
Compare
Done some updates to this. It should now work with either 16.04 (Xenial) or 18.04 (Bionic) and either Python 2 or 3 so it's quite flexible. There's only two issues for people wanting to continue with 16.04:
|
Maybe we should add a little command to run dist upgrades? |
@partounian wouldn't this mostly just be running |
sudo apt update
sudo apt upgrade
sudo apt dist-upgrade
sudo apt autoremove
sudo apt install update-manager-core
sudo do-release-upgrade |
Ah thanks. But still I'd worry about trying to run all those tasks unattended. |
b12ad10
to
0f69bfe
Compare
4d5391f
to
6bd2ece
Compare
6bd2ece
to
28e9850
Compare
@@ -1,6 +1,6 @@ | |||
mariadb_keyserver: keyserver.ubuntu.com | |||
mariadb_keyserver: "hkp://keyserver.ubuntu.com:80" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I switched this back to non-hkps because 16.04 doesn't support it. I'm fine with keeping this "non-secure" version since the official MariaDB instructions use this as well. It makes it way easier for people to stay on 16.04 for now.
Adds support for the new Ubuntu 18.04 Bionic LTS release. This also defaults to Bionic in development (via the default Vagrant box).
This change is marked as
[BREAKING]
. Read below for more details.Trellis will continue to work on both 16.04 and 18.04. If you want to update Trellis to the latest version but continue using 16.04 Xenial, you'll encounter two minor issues to deal with:
vagrant_box
andvagrant_box_version
options invagrant.default.yml
to the 16.04 values you previously had. Or better yet, create avagrant.local.yml
config to override those default values.