Fix raw_vars feature to properly handle int values #959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swalkinshaw
approved these changes
Mar 8, 2018
The raw_vars feature was processing only AnsibleUnicode values. It was not processing int values, replacing them with None.
fullyint
force-pushed
the
raw-vars-int-values
branch
from
f4dda78 to
bda8fac
Compare
primozcigler
added a commit
to proteusthemes/pt-ops
that referenced
this pull request
Mar 13, 2018
* trellis/master: Ensure Diffie-Hellman group is generated for Let's Encrypt (roots#964) Fix raw_vars feature to properly handle int values (roots#959) Update Ansible default plugin paths in config files (roots#958) Add Nginx ssl.no-default.conf to drop requests for unknown hosts (roots#888) Disable memcached UDP support by default Git: Ignore `vagrant.local.yml` Add sponsors [ci skip] Set Vagrant's ansible compatibility_mode Check and stop php7.1-fpm service Update to PHP 7.2 Fix failed_when in template_root check with wp-cli 1.5.0 (roots#948) Bump Ansible version_tested_max to 2.4.3.0 (roots#945) Update wp-cli to 1.5.0 (roots#944) Update `vagrant_box_version` to `>= 201801.02.0` Update `vagrant_box_version` to `<= 201801.02.0` Update Vagrant requirement to v2.0.1. Support for IPv6 in Letsencrypt challenges Allow Trellis VMs to be created/provisioned in Windows Subsystem for Linux.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://discourse.roots.io/t/trellis-site-passwords-not-syncin/10438
The
raw_varsfeature was processing onlyAnsibleUnicodevalues. It was not processingintvalues, replacing them withNone. It appears this issue has existed since the feature was added in #615 where I apparently only ever tested string values.