Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ansible 2.4 compatibility #895

Merged
merged 2 commits into from
Sep 24, 2017
Merged

Ansible 2.4 compatibility #895

merged 2 commits into from
Sep 24, 2017

Conversation

fullyint
Copy link
Contributor

  • update include to import_tasks, include_tasks or import_playbook (docs and docs).
    This avoids deprecation warning. However, server.yml will still show deprecation warning till the composer galaxy role changes these two includes.
  • bump Ansible requirement to 2.4 to accommodate import_* and include_*
  • add warning for Ansible versions greater than tested with Trellis
    It happens that people update Ansible but not Trellis, then run into problems, not realizing they need to update their Trellis for compatibility, posting on discourse, etc.
    [WARNING]: You Ansible version is 2.5.0.0 but this version of Trellis has only been tested for
    compatability with Ansible 2.4.0.0 -> 2.4.2.0. It is advisable to check for Trellis updates or
    downgrade your Ansible version.
    
  • adjust when conditions: failed and success no longer account for rc
  • move dynamic HostKeyAlgorithms from --ssh-extra-args to environment keyword
    --ssh-extra-args seemed to no longer have any effect (maybe related?)
  • accommodate potential for multiple inventories (inventory list in cli.options)

    It is now possible to specify mulitple inventory sources in the command line (-i /etc/hosts1 -i /opt/hosts2) --Ansible CHANGELOG

  • remove loader kwarg from VariableManager.get_vars()

- update `include` to `import_tasks`, `include_tasks` or `import_playbook`
- bump Ansible requirement to 2.4 to accommodate `import_*` and `include_*`
- add warning for Ansible versions greater than tested with Trellis
- adjust `when` conditions: `failed` and `success` no longer account for `rc`
- move dynamic HostKeyAlgorithms from `--ssh-extra-args` to `environment` keyword
- accommodate potential for multiple inventories (`inventory` list in `cli.options`)
- remove `loader` kwarg from VariableManager.get_vars()
@franzliedke
Copy link

Great work. 👍

A silent upgrade to Ansible 2.4 means we can not deploy our site anymore. Took us a while to find out that the Ansible upgrade was the problem.

Copy link
Member

@swalkinshaw swalkinshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working 👍

@fullyint fullyint merged commit 4a2a70a into master Sep 24, 2017
@fullyint fullyint deleted the ansible-2.4 branch September 24, 2017 23:08
@franzliedke
Copy link

Great, thanks! Can we get a new release as well? 😇

@ztackett11
Copy link

How can I go about adding these changes to my trellis repo? i think i was able to update trellis to rc 2 (I think)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants